Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Various CI improvements #8

Merged
merged 1 commit into from
Aug 28, 2024
Merged

ci: Various CI improvements #8

merged 1 commit into from
Aug 28, 2024

Conversation

popzxc
Copy link
Member

@popzxc popzxc commented Aug 28, 2024

  • Add better identifiers for PR name lint job
  • Run actual CI only if code changes
  • Pin action versions

EmilLuta
EmilLuta reviewed Aug 28, 2024
View reviewed changes
Copy link
Contributor

@EmilLuta EmilLuta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to have rennovate bot instead, as discussed in other PRs (instead of pinning)?

@popzxc
Copy link
Member Author

popzxc commented Aug 28, 2024

We may want to have rennovate bot instead, as discussed in other PRs (instead of pinning)?

We may; though I'm not certain how much time it will take to setup it here (we only discussed core). I'm playing with repo settings right now to prepare it for release-please, and use this PR as a target for tests, so it's a bunch of random things that came to my mind quickly.

@popzxc popzxc merged commit 6850b57 into main Aug 28, 2024
13 checks passed
@popzxc popzxc deleted the popzxc-ci-improvements branch August 28, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EmilLuta EmilLuta EmilLuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@popzxc @EmilLuta